Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ci: drop trailing whitespaces #1292

Merged
merged 2 commits into from
Nov 17, 2021
Merged

✨ci: drop trailing whitespaces #1292

merged 2 commits into from
Nov 17, 2021

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Nov 17, 2021

This should help to prevent various linters from complaining about
trailing whitespaces when the file is copy-pasted to other repositories:

.github/workflows/scorecard-analysis.yml:2: trailing whitespace.
+on:
.github/workflows/scorecard-analysis.yml:18: trailing whitespace.
+
.github/workflows/scorecard-analysis.yml:40: trailing whitespace.
+

@evverx
ci: drop trailing whitespaces
48579fa 
This should help to prevent various linters from complaining about
trailing whitespaces when the file is copy-pasted to other repositories:
```
.github/workflows/scorecard-analysis.yml:2: trailing whitespace.
+on:
.github/workflows/scorecard-analysis.yml:18: trailing whitespace.
+
.github/workflows/scorecard-analysis.yml:40: trailing whitespace.
+
```
@evverx evverx changed the title ✨ci: tighten scorecard action a bit and drop trailing whitespaces ✨ci: drop trailing whitespaces Nov 17, 2021
naveensrinivasan
naveensrinivasan approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@naveensrinivasan
Copy link
Member

/ok-to-test sha=48579fa6848848a28b8f5f5b4e537c3f89940354

@naveensrinivasan
Copy link
Member

@laurentsimon 👀 please

@github-actions
Copy link

Integration tests success for 48579fa6848848a28b8f5f5b4e537c3f89940354

laurentsimon
laurentsimon approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@laurentsimon laurentsimon enabled auto-merge (squash) November 17, 2021 16:59
@laurentsimon laurentsimon merged commit b4e3205 into ossf:main Nov 17, 2021
@evverx evverx deleted the scorecard-action branch November 17, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@naveensrinivasan naveensrinivasan naveensrinivasan approved these changes

@azeemshaikh38 azeemshaikh38 Awaiting requested review from azeemshaikh38

@inferno-chromium inferno-chromium Awaiting requested review from inferno-chromium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evverx @naveensrinivasan @laurentsimon